Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

realsense2_camera: 4.54.1-1 in 'rolling/distribution.yaml' [bloom] #37807

Closed
wants to merge 1 commit into from
Closed

realsense2_camera: 4.54.1-1 in 'rolling/distribution.yaml' [bloom] #37807

wants to merge 1 commit into from

Conversation

SamerKhshiboun
Copy link
Contributor

Increasing version of package(s) in repository realsense2_camera to 4.54.1-1:

realsense2_camera

* Applying AlignDepth filter after Pointcloud
* Publish /aligned_depth_to_color topic only when color frame present
* Support Iron distro
* Protect empty string dereference
* Fix: /tf and /static_tf topics' inconsistencies
* Revamped the TF related code
* Fixing TF frame links b/w multi camera nodes when using custom names
* Updated TF descriptions in launch py and readme
* Fixing /tf topic has only TFs of last started sensor
* add D430i support
* Fix Swapped TFs Axes
* replace stereo module with depth module
* use rs2_to_ros to replace stereo module with depth moudle
* calculate extriniscs twice in two opposite ways to save inverting rotation matrix
* fix matrix rotation
* Merge branch 'ros2-development' into readme_fix
* invert translation
* Added 'publish_tf' param in rs launch files
* Indentation corrections
* Fix: Don't publish /tf when publish_tf is false
* use playback device for rosbags
* Avoid configuring dynamic_tf_broadcaster within tf_publish_rate param's callback
* Fix lower FPS in D405, D455
* update rs_launch.py to support enable_auto_exposure and manual exposure
* fix timestamp calculation metadata header to be aligned with metadata json timestamp
* Expose USB port in DeviceInfo service
* Use latched QoS for Extrinsic topic when intra-process is used
* add cppcheck to GHA
* Fix Apache License Header and Intel Copyrights
* apply copyrights and license on project
* Enable intra-process communication for point clouds
* Fix ros2 parameter descriptions and range values
* T265 clean up
* fix float_to_double method
* realsense2_camera/src/sensor_params.cpp
* remove T265 device from ROS Wrapper - step1
* Enable D457
* Fix hdr_merge filter initialization in ros2 launch
* if default profile is not defined, take the first available profile as default
* changed to static_cast and added descriptor name and type
* remove extra ';'
* remove unused variable format_str
* publish point cloud via unique shared pointer
* make source backward compatible to older versions of cv_bridge and rclcpp
* add hdr_merge.enable and depth_module.hdr_enabled to rs_launch.py
* fix compilation errors
* fix tabs
* if default profile is not defined, take the first available profile as default
* Fix ros2 sensor controls steps and add control default value to param description
* Publish static transforms when intra porocess communication is enabled
* Properly read camera config files in rs_launch.py
* fix deprecated API
* Add D457
* Windows bring-up
* publish actual IMU optical frame ID in IMU messages
* Publish static tf for IMU frames
* fix extrinsics calculation
* fix ordered_pc arg prefix
* publish IMU frames only if unite/sync imu method is not none
* Publish static tf for IMU frames
* add D430i support
* Contributors: Arun Prasad, Arun Prasad V, Arun-Prasad-V, Christian Rauch, Daniel Honies, Gilad Bretter, Nir Azkiel, NirAz, Pranav Dhulipala, Samer Khshiboun, SamerKhshiboun, Stephan Wirth, Xiangyu, Yadunund, nvidia

realsense2_camera_msgs

* add info about extrinsic msg format in Extrinsics.msg and README.md
* Expose USB port in DeviceInfo service
* Fix Apache License Header and Intel Copyrights
* apply copyrights and license on project
* Contributors: Arun Prasad, Nir Azkiel, SamerKhshiboun, Stephan Wirth

realsense2_description

* Update mesh path
* clone PR1637 to ros2-development
* Fix Apache License Header and Intel Copyrights
* apply copyrights and license on project
* Replace deprecated parameter node_name with name
* Contributors: Arun Prasad, Nir Azkiel, SamerKhshiboun, augustelalande, marqrazz

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jun 29, 2023
@Nir-Az
Copy link
Contributor

Nir-Az commented Jun 29, 2023

Note: This package depends on #37808

clalancette
clalancette requested changes Jun 30, 2023
View reviewed changes
rolling/distribution.yaml
- realsense2_description
tags:
release: release/rolling/{package}/{version}
url: https://github.com/IntelRealSense/realsense-ros-release.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as #37808 (comment) applies here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened PR, waiting for merge:
ros2-gbp/ros2-gbp-github-org#297

@clalancette clalancette added the changes requested Maintainers have asked for changes to the pull request label Jun 30, 2023
@github-actions
Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Jul 16, 2023
@SamerKhshiboun
Copy link
Contributor Author

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

Hi @clalancette, we are still waiting for PR merge in ros2-gbp
ros2-gbp/ros2-gbp-github-org#297

Please keep this PR open by labeling it as "persistent"

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Jul 17, 2023
@clalancette clalancette added the persistent Issue/PR won't be marked as stale if inactive for a while. label Jul 17, 2023
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Aug 9, 2023
@sloretz
Copy link
Contributor

sloretz commented Aug 9, 2023

Holding for an upcoming Rolling sync

@mjcarroll mjcarroll added ros2-gbp Pending release into ros2-gbp and removed held for sync Issue/PR has been held because the distribution is in a sync hold labels Aug 29, 2023
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 27, 2023
@sloretz
Copy link
Contributor

sloretz commented Sep 27, 2023

Holding for an upcoming Rolling sync

@sloretz sloretz removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Oct 2, 2023
@clalancette
Copy link
Contributor

I'm going to close this PR until the discussion in ros2-gbp/ros2-gbp-github-org#297 is sorted out. Once that is done, a new PR is going to have to be opened anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette requested changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich nuclearsandwich is a code owner

Assignees
No one assigned
Labels
changes requested Maintainers have asked for changes to the pull request persistent Issue/PR won't be marked as stale if inactive for a while. rolling Issue/PR is for the ROS 2 Rolling distribution ros2-gbp Pending release into ros2-gbp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamerKhshiboun @Nir-Az @sloretz @clalancette @mjcarroll